Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification manager functionality: notification tool and category support #8

Merged
merged 5 commits into from Sep 24, 2012

Conversation

Vesuri
Copy link

@Vesuri Vesuri commented Sep 21, 2012

The tool is meant for testing the notification manager from the command line. It allows notifications to be added, updated and
removed. The notification manager current debug prints notification operations. This will be removed as soon as there is a better way to visualize notifications.

Category definition files allow configuring the behavior of notifications in each category. The category definition store loads the configuration files and adds the category definition parameters as hints in the notification when one is sent or updated.

@@ -1,6 +1,6 @@
TEMPLATE = subdirs
CONFIG += ordered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmph. we should be avoiding this and using foo.depends, for maximum impact of parallel builds

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be more elaborate? I don't know how to fix this the way you want based on this comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was more a note to myself (as you didn't add this), but, qmake supports explicit dependencies between targets, so for instance, this could be:

plugin.depends = src
tools.depends = src

and once src was built, both plugin and tools could be built in parallel assuming make -j

Vesa Halttunen added 5 commits September 24, 2012 13:53
The tool is meant for testing the notification manager from the command line. It allows notifications to be added, updated and
removed. The notification manager current debug prints notification operations. This will be removed as soon as there is a better
way to visualize notifications.
NotificationHints accidentally got serialization code which isn't needed (at least for now), so removing.
Adds a public API for getting a singleton instance of the manager in order to get signals about new, updated and removed
notifications in the UX implementations.
Components seems to contain UI components, so let's not clutter it up with notification stuff
Category definition files allow configuring the behavior of notifications in each category. The category definition store loads
the configuration files and adds the category definition parameters as hints in the notification when one is sent or updated.
rburchell added a commit that referenced this pull request Sep 24, 2012
Notification manager functionality: notification tool and category support
@rburchell rburchell merged commit 0b74c11 into nemomobile:master Sep 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants