Fix minor memory leaks and remove blocking dbus calls #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While closing logging is not necessary, doing it reduces noise during memory leak debugging. In the code the logging cleanup was made on abnormal exit paths, but omitted when making an orderly exit. Remove unnecessary mce_log_close() calls from abnormal exit paths. Perform logging cleanup actions on normal exit.
While file monitoring signal was disconnected and monitoring cancelled, the related gobjects were not cleaned up. Omit unnecessary g_file_monitor_cancel() calls and make appropriate g_object_unref() calls. Also change initially available device scanning to happen after the directory monitoring is in place.
All datapipes initialized with setup_datepipe() should also be cleaned up via free_datapipe(). Add missing free_datapipe() call for camera button datapipe.
Static symbols etc were missing from mce debuginfo packages because extra debug information was not generated during compilation. Use '-g' option both for compilation and linking.
The standard dbus_bus_name_has_owner() function from libdbus uses blocking D-Bus method call. Use custom asynchronous query instead.
The dbus_connection_flush() can block and is not needed since the connection is bound to the glib mainloop. Remove potentially blocking The dbus_connection_flush() calls.
Leaving callback functions from unloaded modules active can cause mce crashes on exit path. Remove all installed gconf notifiers when modules are unloaded at mce exit time.
spiiroin
added a commit
that referenced
this pull request
Sep 2, 2014
Fix minor memory leaks and remove blocking dbus calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing / fix incorrect dynamic resource releasing at mce exit path. Does not change behavior during runtime, but should reduce noise in future memory leak hunts.
Also removes potentially blocking D-Bus connection flushing and replaces blocking D-Bus name owner
queries with asynchronous logic.
[mce] Fix minor memory leaks and remove blocking dbus calls. Fixes JB#22450