Signal hw keyboard availability and slide-in keypad position over D-Bus #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using abstract gpointer instead of pointer to io monitor structure makes following logic from callbacks up to io monitor functionality harder than it needs to be. Use typed pointer instead of abstact gpointer for io monitor functions. Use uniform naming for io monitor functions. Remove unused io monitor error callback function type. No functional changes. [mce] Refactor mce io monitor interface
Rename functions, data types and variables to reflect logical grouping and move items in each logical group close to each other. Switch indentation to use 4 spaces instead of 1 tabulator. Remove unused legacy ini-file config items. No significant functional changes.
When slide in keypad is opened/closed, a keypad_slide_state_ind signal
is broadcast over D-Bus System Bus.
<node name="/com/nokia/mce/signal">
<interface name="com.nokia.mce.signal">
<signal name="keypad_slide_state_ind">
<arg name="keypad_state" type="s"/>
</signal>
</interface>
</node>
Current state can be queried from mce with keypad_slide_state_req D-Bus
method call.
<node name="/com/nokia/mce/request">
<interface name="com.nokia.mce.request">
<method name="keypad_slide_state_req">
<arg direction="out" name="keypad_state" type="s"/>
</method>
</interface>
</node>
[mce] Signal slide in keypad state over D-Bus System Bus
After io monitor is created, used data can be attached to it via mce_io_mon_set_user_data(). The existing notification interface is not changed, i.e. the user data is not automatically passed to notification callbacks and must be queried via mce_io_mon_get_user_data() function when needed. If free callback is provided, the user data is released when the io monitor itself gets deleted. [mce] Allow attaching of context specific user data to mce io monitors
Classify evdev nodes that send KEY_Q and KEY_P events as keyboards
or slide-in keypads depending on whether they also emit SW_KEYPAD_SLIDE
switch state events.
Maintain a hw-keyboard-is-available state - which is true as long as
there exists at least one keyboard device or slide-in keypad in open
position.
When availability state changes, a keypad_available_state_ind signal
is broadcast over D-Bus System Bus.
<node name="/com/nokia/mce/signal">
<interface name="com.nokia.mce.signal">
<signal name="keypad_available_state_ind">
<arg name="keypad_state" type="s"/>
</signal>
</interface>
</node>
Current state can be queried from mce with keypad_available_state_req
D-Bus method call.
<node name="/com/nokia/mce/request">
<interface name="com.nokia.mce.request">
<method name="keypad_available_state_req">
<arg direction="out" name="keypad_state" type="s"/>
</method>
</interface>
</node>
[mce] Signal hw keyboard availability state over D-Bus System Bus. Fixes JB#25232
Using signals/state data names with "keypad" causes confusion. When dealing with input devices that are expected to be qwerty keyboards, use names that have "keyboard" instead of "keypad".
spiiroin
added a commit
that referenced
this pull request
Jan 12, 2015
Signal hw keyboard availability and slide-in keypad position over D-Bus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.