Fix USB cable connection related issues in display blanking policy #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add compositor available datapipe and update it from display plugin.
Many datapipes have their content managed by plugins. This makes the initial state evaluation depend on the plugin load order and just installing change notifiers might result in missing the first changes. The tklock module has array based datapipe binding helpers that use idle callback to ensure that the datapipe state after mce startup is fed to notification callbacks. Move the array based binding utilities to datapipe module and make available for all mce modules.
Having separate function calls for installing and removing each datapipe listener makes it hard to see if every listener that is installed is also removed. Also there are no quarantees that initial state guesses made in display plugin match the state that has been reached at the time when display plugin is loaded. Use array based datapipe binding utilities for installing and removing callbacks. The datapipe states are fed to callbacks after mce mainloop reaches idle.
Spotting changes in verbose startup logging is difficult when mce must be stopped manually. Add auto-exit feature that by default makes mce exit 5 seconds after mainloop reaches idle.
There are multitudes of local dbus service tracking variants scattered around mce code base. The lipstick state is needed by tklock core module and provided by in theory optional display plugin. Move the name owner tracking implemented in display plugin to mce-dbus so that it can be used as common implementation for tracking all dbus services that are essential for mce operation. Initially use it for tracking availability of lipstick and compositor service.
|
LGTM |
There is logic in mce to process charging state separately from usb cable connect state, but since the legacy logic for detecting does not work charging status has been used for things that should depend on cable connect. This delays things like turning on display to show usb mode selection dialog and makes it hard to decide how long the display should be kept on. And turning on display when mce starts up while usb cable is already attached can cause problems during 1st boot if the display state restoration occurs close to starting up of the startup wizard. Use usb mode provided by usb_moded to determine usb cable state. The usb_moded tracking logic is derived from the implentation used in dsme. Both mce and dsme use LGPL v2.1 license. Use separate display on rules for charging and cable connect changes. Do not turn on the display when cable is removed / charging stops. Do not turn on the display if usb cable is already connected when mce is started. Fix glitches in display state handling and automatic brightness tuning during mce startup. [mce] Fix USB cable connection related issues in display blanking policy. Fixes JB#25788
spiiroin
added a commit
that referenced
this pull request
Jan 23, 2015
Fix USB cable connection related issues in display blanking policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.