Get battery data from statefs #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helpers for getting state names and use them in diagnostic logging.
Performs similar task as existing battery_bme and battery_upower plugins, but gets the battery data from files maintained by the statefs service. Checks presense of required propery files in /run/state/namespaces/Battery directory on mce startup. If files are not present, or become not available later on due to stopping and/or restarting of statefs service, periodic checks are made to detect when they come available again. While the files available, the battery level, status and charging activity state changes are tracked and pushed to datapipes in the form existing mce logic is expecting. [mce] Add plugin for tracking battery state via statefs. Contributes to JB#6273
By default load statefs battery plugin instead of the upower one. [mce] Get battery data from statefs. Fixes JB#6273
It is more or less expected that end of notification can occur later than expected and there is no harm in ending notification state even though one is not even started. Hence there is no need to spam the journal with these messages on default logging verbosity.
| sfsbat_state_t state; | ||
| } state_lut[] = | ||
| { | ||
| { "charging", STATEFS_BATTERY_STATE_CHARGING }, |
There was a problem hiding this comment.
I recommend you to add also "unknown" state tracking, adding it instead of separate IsValid (or similar) property
There was a problem hiding this comment.
It is kind of built into startup defaults, but handling it explicitly is clearer (and works if battery should for some reason go to unknown state after initial probing too). Will fix.
There was a problem hiding this comment.
On the other hand you are right: maybe "unknown" should be anything except known values. Also empty string is suitable for this state.
The logic assumed that battery is in unknown state until statefs reports transition to [charging, discharging, full, empty] is seen. However transitions to unknown state are ignored and the previous state is kept. Add "unknown" to set of expected Battery.State values. Treat empty string as an alias for "unknown". Unrecognized string values are treated similarly as "unknown", but a warning is emitted to journal.
spiiroin
added a commit
that referenced
this pull request
Jan 27, 2015
Get battery data from statefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.