Add support for constant velocity brightness changes #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCE_GCONF_DISPLAY_PATH was defined in two places. Possibly due to moving option names away from display.h after separate als brightness filtering plugin was created - long time ago. Define all constants derived from MCE_GCONF_DISPLAY_PATH in display.h and adjust naming of the values to match style used in display.h.
Previously MCE did all brightness adjustments via constant velocity engine. This was replaced with constant duration engine which is more suitable for quick fade in/out animations associated with display state changes, but some users prefer constant velocity brightness tuning when ALS adjustments are made. If fade length settings have negative values, they are interpreted to be constant velocity change of %/s type. Which means that for example mcetool --set-brightness-fade-als=-50 causes ALS adjustment happen in constant velocity that animates from zero to maximum brightness in two seconds. To keep the negative numbers from causing serious usability issues if used for something else in addition to ALS tuning, the transition lengths are capped so that they take maximum of 5 seconds. Also, to keep the reaction to changes via settings ui responsive, the brightness tuning happening immediately after config changes is made to happen relatively fast contrary to possible fader length settings. [mce] Add support for constant velocity brightness changes. Fixes JB#25458
spiiroin
added a commit
that referenced
this pull request
Jan 28, 2015
…tness Add support for constant velocity brightness changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.