Stop initial orientation reporting from triggering flip over gestures #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many cases the helpers were created at the module that is primarily responsive for maintaining the datapipe content and datapipe listeners do debug logging using the numeric states - which requires effort to decode. Move state enum to string helper functions to datapipe.c and list prototypes in mce.h next to enum type declaration.
If device was face-up the last time orientation sensor was enabled, sensord can report and mce assume that it is still face-up when the sensor is powered up the next time. This can make it look like the device were flipped over during sensor startup, which then silences incoming call / snoozes alarm (if device is face-down and proximity sensor is not blocking display & sensor power up). Make mce forget orientation sensor state altogether when the sensor is stopped. And make sensor-gestures plugin wait a bit longer before accepting face-up immediately after sensor power up. [mce] Stop initial orientation reporting from triggering flip over gestures. Fixes NEMO#786
|
Code style LGTM |
|
Tested branch spiiroin:nemo786_flipover_gesture and the symptoms described in NEMO#786 are not reproducible. |
These state changes are side effects of starting/stopping the use of orientation sensor and thus do not constitute user activity.
Now that the helpers are available, use them to make debug logging easier to read. No functional changes.
Using current display state for evaluating need for orientation sensor works logically right, but delays sensor ramp up a bit making it likely that correct orientation is known after display is already in fully powered up state. Use target display state instead. This allows sensor ramp up to start earlier and makes it more likely we have correct orientation by the time display reaches on state.
Old forgotten fixme spotted. LPM states are in use now and from sensor use point of view LPM_ON display state is equal to ON and DIM states.
spiiroin
added a commit
that referenced
this pull request
Feb 4, 2015
Stop initial orientation reporting from triggering flip over gestures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.