Make all blanking timeouts separately configurable #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using helper functions for getting initial setting value and installing change notifier callback allows bit more compact code and makes it a bit more difficult to make obvious errors. Switch to using helper functions and add FIXMEs for problems spotted while doing it. No functional changes. [mce] Use mce_gconf_track_xxx() helpers in display plugin. Contributes to JB#26550
The default and fallback values for settings should match. Having both of them hard coded makes it too easy to get them out of sync. Initialize fallback values from named constants. When possible use the same constants to initialize also the built-in config defaults. No functional changes. [mce] Do not use hardcoded defaults for display plugin settings. Contributes to JB#26550
No change notification for dim timeouts setting was installed, which meant change did not get effective without mce restart. Also no fallback values were provided in case the config item is not available. Use common defaults for built-in config and fallback values. If dim timeouts setting changes, adjust related state variables and reprogram blanking timers. [mce] Provide fallback values dim timeouts setting and track changes. Contributes to JB#26550
We'd like to have different delays when blanking from application/home view (ON->DIM->OFF, relatively short delay) vs blanking from lockscreen (ON->OFF, give user some time to interact with the gui). Also it might be desirable to have better control over ON->LPM_ON->LPM_OFF->OFF transitions. Now LPM_OFF delay is hard coded and the rest use the same configuration setting. Provide separate blanking delay settings to use from: * application/home screen after dimming (default 3 seconds) * lockscreen (default 10 seconds) * visual low power mode (default 5 seconds) * blanked low power mode (default 5 seconds) The defaults can changed by installing config files to /etc/mce. And tweaked during runtime via D-Bus or mcetool options: --set-blank-timeout=<secs> --set-blank-from-lockscreen-timeout=<secs> --set-blank-from-lpm-on-timeout=<secs> --set-blank-from-lpm-off-timeout=<secs> The changes made during runtime persist over mce/device restarts. Also make sure the inactivity timeout is re-evaluated when parameters it depends on are changed. [mce] Make all blanking timeouts separately configurable. Fixes JB#26550
spiiroin
added a commit
that referenced
this pull request
Feb 20, 2015
Make all blanking timeouts separately configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.