Add option to ignore tklock removal while device lock is active #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using helper functions for getting initial setting value and installing change notifier callback allows bit more compact code and makes it a bit more difficult to make obvious errors. Initialize fallback values from named constants. When possible use the same constants to initialize also the built-in config defaults. No functional changes.
The tklock status more or less equals "lockscreen is active". And removing tklock switches from lockscreen to home/app view. This is problematic if device unlocking should happen in the context of the lockscreen as power key actions / random tklock request from applications could effectively bypass the device lock. Add configuration setting "devicelock is in lockscreen". While the setting is enabled, mce will not allow removal of tklock while device lock is active. By the default the setting is disabled. Changing the setting should happen via installing configuration file to /etc/mce directory if (and only if) the ui side actually implements device unlocking within lockscreen. The option can also be toggled via mcetool. But since inappropriate use can make the device unlockable from ui, the mcetool option is flagged as dangerous and interactive confirmation is required. [mce] Add option to ignore tklock removal while device lock is active. Fixes JB#26525
spiiroin
added a commit
that referenced
this pull request
Mar 15, 2015
Add option to ignore tklock removal while device lock is active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.