Drop legacy logic for direct proximity and ambient light sensor control #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In maemo/meego times mce controlled proximity sensor directly via kernel interfaces and sensorfw asked mce to start/stop sensor via dbus interface. Nowadays it is the other way around, but old unused proximity sensor code is still littering mce code base. Remove unused sensor control code and drop support dbus method calls. [mce] Remove legacy proximity sensor logic. Contributes to JB#27286
In maemo/meego times mce controlled ambient light sensor directly via kernel interfaces and sensorfw asked mce to start/stop sensor via dbus interface. The legacy logic for direct sensor control has already been removed earlier, but the unneeded dbus methods for starting/stopping the sensor are still littering mce code base. Drop support starting/stopping ambient light sensor via dbus method calls. [mce] Remove legacy ambient light sensor logic. Contributes to JB#27286
…tional The legacy sensor control methods are removed, only sensorfw can be used for starting/stopping sensors. If sensord is not running on the device or does not support some of the expected to be available sensors, mce will still function and uses sensible fallback values for sensors. Remove the build time configuration for disabling sensorfw usage. [mce] Using sensorfw for ambient light / proximity sensor control is not optional. Fixes JB#27286
|
LGTM |
1 similar comment
|
LGTM |
|
Tried these on N9 running Nemo and everything appears to be working (for PS, call was simulated with mcetool -c ringing:normal -B1 -c active:normal -B and covering/uncovering PS) In other words LGTM |
spiiroin
added a commit
that referenced
this pull request
Mar 15, 2015
Drop legacy logic for direct proximity and ambient light sensor control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.