Allow simulating also outgoing calls #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to the intent described in the comment, the call state simulation logic does not allow switching to active call without going through ringing state / using emergency call type. Make the validity checks match the explanatory comment.
Use warning level for reporting invalid parameters supplied by client and error level for reporting internal failures. Use appropriate call state and type constants instead of the generic MCE_INVALID_TRANSLATION. Use !xxx() instead of xxx() == FALSE in conditionals. No functional changes.
spiiroin
added a commit
that referenced
this pull request
Jul 30, 2015
Allow simulating also outgoing calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.