generateDisplayLabel doesnt follow SeasideCache::displayLabelOrder()

[CODeRUS]

Check
https://github.com/nemomobile/nemo-qml-plugin-contacts/blob/master/src/seasideperson.h#L345
Why hardcoded order and not using SeasideCache::displayLabelOrder() here?

[matthewvogt]

No good reason - it should use the configured default.

[CODeRUS]

It shouldnt have this property at all since displayLabelOrder is readonly and follow system settings.

[matthewvogt]

I don't see any reason to restrict the use of this static utility function, simply because the behavior of the instances is constrained to follow the default.

[CODeRUS]

Problem is not generateDisplayLabel function itself.
Problems are:
https://github.com/nemomobile/nemo-qml-plugin-contacts/blob/master/src/seasideperson.cpp#L118
https://github.com/nemomobile/nemo-qml-plugin-contacts/blob/master/src/seasideperson.cpp#L128
even https://github.com/nemomobile/nemo-qml-plugin-contacts/blob/master/src/seasideperson.cpp#L268
because of recalculateDisplayLabel(). It's never called with right order (https://github.com/nemomobile/nemo-qml-plugin-contacts/blob/master/src/seasideperson.cpp#L2214 is never called)
And because of that displayLabel property (https://github.com/nemomobile/nemo-qml-plugin-contacts/blob/master/src/seasideperson.h#L210) doesnt follow system First/LastNameFirst order and always generated with FirstNameFirst order.

[matthewvogt]

Agreed. So, the fix should be to change the default argument to be the result of invoking SeasideCache::displayLabelOrder(), right?

[CODeRUS]

exactly. displayLabel property should be generated with SeasideCache::displayLabelOrder()

[matthewvogt]

#104

Thanks for the report.

[CODeRUS]

Thank you! Waiting for upstream release :)