New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash if invalid row given. #115

Closed

vranki wants to merge 1 commit into nemomobile:master from vranki:personByRowBug

vranki commented Aug 25, 2014

Return null instead of crashing if row is invalid.


          Fix crash if invalid row given.

107c09d

SfietKonstantin reviewed

View reviewed changes

src/seasidefilteredmodel.cpp

               SeasidePerson *SeasideFilteredModel::personByRow(int row) const
               {
-                  return personFromItem(SeasideCache::itemById(m_contactIds->at(row)));
+                  if (row >= 0 && row < m_allContactIds->size()) {
+                      return personFromItem(m_allContactIds->at(row));

Member

SfietKonstantin Aug 25, 2014

Old code was "return SeasideCache::itemById(m_contactIds->at(row))"
yours is return m_contactIds->at(row). You missed something here ;)

vranki closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment