New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nemo-qml-plugin-dbus] add QDBusVariant type to typedCall marshaling #31
base: master
Are you sure you want to change the base?
Conversation
|
What's 'z'? Can't find it in any spec. |
|
Actually i don't know what single letter to assign for this type |
|
QDbusVariant is just a superset of QVariant? Do you need a specialization for it? |
|
I wouldn't make a PR if it will work with just QVariant. QDBusVariant is necessary to have. |
|
@CODeRUS Can you explain any use case? |
sending set_config with anything except QDBusVariant is not allowed |
|
Should the 'v' case be updated instead of inventing a new letter? |
|
To me the whole function feels wrong. Instead of assuming random js variable can be returned |
|
@monich can be if it don't break anything using QVariant |
|
How does this relate to #30 ? Maybe we can solve the issue with either of these fixes? |
|
@thp it's not related. Just both PR is about using QDBusVariant from qml side. One is for receiving QDBusVariant value and mine is for sending QDBuaVariant |
|
After 2nd look... The existing 'v' case does not guarantee that dbus variant gets used = is broken. The 'z' one by coderus does -> drop the non-standard 'z' and use the logic to handle the 'v' case? |
|
This needs updating if we want to merge it. |
|
@CODeRUS Do you think we can get this rebase against the master and merged? |
No description provided.