Qt5 packaging. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please use interactive rebase (git rebase -i) to squash these into one commit also, while doing so, reword the commit message to contain a subject in between square brackets, e.g: otherwise we can't release it |
|
you appear to be replacing the Qt 4 packaging with this. I'd suggest just changing the dependencies and so on without renaming the package (drop the -qt5 prefix), given that there aren't many other users of it. |
|
Ok, removed -qt5 postfix and reworded commits. |
| Provides: nemo-qml-plugins-folderlistmodel > 0.3.5 | ||
| BuildRequires: pkgconfig(Qt5Core) | ||
| BuildRequires: pkgconfig(Qt5Declarative) | ||
| Provides: nemo-qml-plugins-folderlistmodel-qt5 > 0.3.5 |
|
Ok, dropped. |
| - QtCore >= 4.7.0 | ||
| - QtDeclarative | ||
| - Qt5Core | ||
| - Qt5Quick |
There was a problem hiding this comment.
you don't actually need Qt5Quick, do you? afair this is entirely non-graphical and thus qml suffices
|
Removed Qt5Quick then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packaged as -qt5 postfix.