ffmemless: Rename settings environment variable #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original plan for the settings environment variable was that we could use the same settings file for qtfeedback and ngfd. Unfortunately QSettings cannot read glib's .ini file format, and vice versa glib cannot comprehend settings values without bracket header. So, change the ngf environment variable to be different from the qtfeedback one, so that separate device/distro specific values can be set in separate files for qtfeedback and ngfd. Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
|
LGTM |
iamer
added a commit
that referenced
this pull request
Aug 16, 2013
[ffmemless] Rename settings environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original plan for the settings environment variable was that
we could use the same settings file for qtfeedback and ngfd.
Unfortunately QSettings cannot read glib's .ini file format,
and vice versa glib cannot comprehend settings values without
bracket header.
So, change the ngf environment variable to be different from
the qtfeedback one, so that separate device/distro specific values
can be set in separate files for qtfeedback and ngfd.
Signed-off-by: Kalle Jokiniemi kalle.jokiniemi@jollamobile.com