Fix issue with ffmemless file descriptor getting closed spuriously #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2013 14:25
Since exec restarts the whole process, there is no point in leaving the file descriptors hanging around. Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
There is a issue that the file descriptor of the vibra device gets closed by something unknown in the system. This causes the kernel to delete all the loaded effects. Subsequently the vibra effects don't work anymore, unless someone else happens to load effects to those id slots that ffmemless plugin thinks are still there. I have straced ngfd, but at least ngfd is not closing the fd. I found that moving the device opening to sink init instead of plugin load, the issue dissappears. My theory is that it has something to do with the plugin loading mechanism, but cannot confirm this unfortunately. As the sink init is actually more logical place to initialize the device node, it makes sense to add this fix in any case. Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
|
LGTM |
kjokinie
pushed a commit
that referenced
this pull request
Sep 27, 2013
Fix issue with ffmemless file descriptor getting closed spuriously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vibra event device node file descriptor gets closed by "something", fixed the issue by moving the device node setup / close to sink_init / sink_shutdown.