Clear old effect before uploading new #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2013 16:56
The ffmemless_erase_effect function declaration was missing from the header file. Added so that the function can be used. Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
If a effect with different type than an existing effect in kernel is uploaded with same id, the effect loading fails. Solved this by deleting the old effect before uploading new ones. Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
kjokinie
pushed a commit
that referenced
this pull request
Oct 18, 2013
Clear old effect before uploading new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a missing function declaration, and then added deleting of effect before uploading new one to make sure that also different kind of adaptation specific effects can work on top of the default ones.