NEMO#402 Exiting slideshow mode doesn't change the index of the displaye... #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayed element I've done some changes to the slideshow mode code, cleaning it a bit and refactoring where was needed (visibleIndex wasn't really representing the index of the displayed element). Also I've refactored ImagePage code (here too, visibleIndex wasn't really representing the index of the displayed element). Moreover, I've changed the slideshow code to make it so that when you pop the slideshow page, you won't be taken to the element where you started the slideshow mode from. This means that if you now exit slideshow mode when element with index i is on screen, you'll see element with index i in the list view mode too, as asked in the bug thread of NEMO#402
|
OK. I would like to see a better implementation of the container in ImagePage eventually; I might be doing something similar for Lipstick soon. Confirmed that NEMO#402 is fixed. |
special
added a commit
that referenced
this pull request
Oct 19, 2012
NEMO#402 Exiting slideshow mode doesn't change the index of the displaye...
|
Yeah, ImageContainer has to be rewritten sooner or later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...d element
I've done some changes to the slideshow mode code, cleaning it a bit
and refactoring where was needed (visibleIndex wasn't really representing
the index of the displayed element).
Also I've refactored ImagePage code (here too, visibleIndex wasn't really
representing the index of the displayed element).
Moreover, I've changed the slideshow code to make it so that when
you pop the slideshow page, you won't be taken to the element where
you started the slideshow mode from.
This means that if you now exit slideshow mode when element with index i is on screen,
you'll see element with index i in the list view mode too, as asked in the bug thread
of NEMO#402