Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEMO#404 Added doubletap zoomin feature (with animation) #20

Merged
merged 1 commit into from Dec 22, 2012

Conversation

faenil
Copy link
Member

@faenil faenil commented Dec 1, 2012

For more info on how the zoomin is performed read the 5th comment on https://bugs.nemomobile.org/show_bug.cgi?id=404

@@ -62,6 +69,51 @@ PinchArea {
isZoomingOut = false
}

//quickZoomIn works in 2 phases:
//1) zoom image (until it fills screen in case we're going to execute phase 2 too)
//2) (ONLY IF the requested scale factor exceeds the screen-filling scale factor) Zoom again centered on the finger position
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why what? :O

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me and @special discussed about the reasons few weeks ago and decided to keep the 2-phases as currently lacking a valid alternative

For more details on how the doublezoom is performed (comment 5):
https://bugs.nemomobile.org/show_bug.cgi?id=404

@special
Copy link
Contributor

special commented Dec 22, 2012

ok

faenil added a commit that referenced this pull request Dec 22, 2012
NEMO#404 Added doubletap zoomin feature (with animation)
@faenil faenil merged commit 1b9d813 into nemomobile:master Dec 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants