Porting to Qt5. #22
Porting to Qt5. #22
Conversation
| BuildRequires: pkgconfig(qdeclarative-boostable) | ||
| BuildRequires: pkgconfig(QtOpenGL) | ||
| BuildRequires: pkgconfig(libresourceqt1) | ||
| Requires: qt-components-qt5 >= 1.4.8 |
There was a problem hiding this comment.
you can drop the version requirement (it'd be useless anyway, there has never been a -qt5 release with a version number that low)
|
Hmm can't see anything in my Kate about that indentation, will fix. Otherwise I did repackage and test it in VM before pushing. |
|
Ok, it was simply spaces for tabs indent ... |
| @@ -3,7 +3,7 @@ Version=1.0 | |||
| Type=Application | |||
| Terminal=false | |||
| Name=Gallery | |||
| Exec=invoker -s --type=d /usr/bin/qmlgallery -fullscreen %u | |||
| Exec=/usr/bin/invoker --single-instance -r 5 --type=qtcomponents-qt5 /usr/bin/qmlgallery -fullscreen %u -platform wayland | |||
There was a problem hiding this comment.
Don't use -platform wayland; let the environment do it
|
Otherwise LGTM |
|
looks OK to me. waiting for @faenil's OK to merge though, as I haven't had too much to do with this :) |
|
|
||
| class QDeclarativeView; | ||
| #include <QQuickView> | ||
| #include <QtQml> |
There was a problem hiding this comment.
wouldn't it be better to leave the forward declaration here? :)
|
Code looks OK to me. Can't test properly on VM because of theme issues, and haven't tested on device as we don't have a wayland image for n950 yet |
Port done to Qt5, with animations working in Wayland.