Connect to QScreen for orientation change updates #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you squash the second commit? maybe @rburchell can review this ;) looks okay to me though |
| @@ -255,6 +254,17 @@ void MDeclarativeScreenPrivate::initContextSubscriber() | |||
| q, SLOT(_q_updateOrientationAngle())); | |||
| QObject::connect(&remoteTopEdgeListener, SIGNAL(nameDisappeared()), | |||
| q, SLOT(_q_updateOrientationAngle())); | |||
|
|
|||
| #elif QT_VERSION >= QT_VERSION_CHECK(5, 0, 0) | |||
| QScreen* screen = QGuiApplication::primaryScreen(); | |||
|
generally looks ok. please also drop the qt4-specific code, if you've some spare time -- this branch is qt5-only (even though it's still littered with conditionals) |
| @@ -66,9 +62,8 @@ class MDeclarativeInputContextPrivate | |||
| MDeclarativeInputContextPrivate(MDeclarativeInputContext *qq); | |||
| ~MDeclarativeInputContextPrivate(); | |||
|
|
|||
| #if QT_VERSION >= QT_VERSION_CHECK(5, 0, 0) | |||
|
|
|||
There was a problem hiding this comment.
Extra newline (just to tell you I reviewed it :D)
|
LGTM after cosmetics |
Style Removed old Qt4 code, MDeclarativeScreenPrivate::physicalOrientation now uses QScreen Cosmetics
sledges
added a commit
that referenced
this pull request
Oct 10, 2013
Connect to QScreen for orientation change updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.