NEMO#511 ToolBar animations now work as expected #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To know more about the bug, read https://bugs.nemomobile.org/show_bug.cgi?id=511 This bug is related to a design issue in QML, which is described here https://bugreports.qt-project.org/browse/QTBUG-16856 To fix the bug: - "" states have been given an explicit name - a new "default" state has been added There was also a wrong boolean condition which has now been fixed.
| name: "" | ||
| when: !(privateVisibility == ToolBarVisibility.Visible || tools == null) | ||
| name: "visible" | ||
| when: (privateVisibility == ToolBarVisibility.Visible && tools != null) |
There was a problem hiding this comment.
Hmm. This means when tools == null, there is no matching state, so it'll use the default, which looks effectively identical to this state (excluding transitions). Does that work the same as before (is it meant to be visible)? In particular, will there be an animation if you change tools from null to non-null while otherwise visible?
There was a problem hiding this comment.
Nevermind. The hidden state matches this case and will trigger transition.
|
LGTM. Thanks. |
special
added a commit
that referenced
this pull request
Oct 13, 2012
NEMO#511: ToolBar animations now work as expected
|
good :) You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To know more about the bug, read https://bugs.nemomobile.org/show_bug.cgi?id=511
This bug is related to a design issue in QML, which is described here
https://bugreports.qt-project.org/browse/QTBUG-16856
To fix the bug:
There was also a wrong boolean condition which has now been fixed.