Patch for #581 : Do not fix implicitWidth #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still applicable? Should we merge this or drop it? // cc @khertan @locusf @rburchell @faenil |
|
This is apparently for the old version of qt-components, before qtquick2 branch. We currently don't package master branch anymore so either this needs to be for qtquick2 branch or we drop this pr. |
|
Indeed it s really old and for QtQuick 1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set a fixed size for implicitWidth of a TextArea this prevent using not wrapping text in a flickable item.
Remove the fixed size to take care of sub Text item, and add ensure visible for horizontal scrolling.