Clean up rotation angle property setting. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was not only messy, it's all kinds of broken. It reset the window id it used every time a window was mapped, which is useful for supporting multiple windows (which admittedly needs investigation), but broke things terribly in that after a map, it would always update the _wrong_ window. This caused a bug in e.g. https://github.com/thp/lipstick-colorful-home/commit/be7a676e8c0513a294f4fc9d4318942ca7be98a4 where something would be mapped, the window id would be reset, and thus the orientation angle for the desktop would never correctly be set again, meaning sysuid would show on the wrong orientation. As another side effect, this should mean that all processes no longer wake up and set their rotation angle (uselessly) on a window being mapped.
|
Fixes the bug mentioned in the commit message for me. What I've tested:
|
rburchell
added a commit
that referenced
this pull request
Feb 21, 2013
Clean up rotation angle property setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was not only messy, it's all kinds of broken. It reset the window id
it used every time a window was mapped, which is useful for supporting multiple
windows (which admittedly needs investigation), but broke things terribly in
that after a map, it would always update the wrong window.
This caused a bug in e.g.
https://github.com/thp/lipstick-colorful-home/commit/be7a676e8c0513a294f4fc9d4318942ca7be98a4
where something would be mapped, the window id would be reset, and thus the
orientation angle for the desktop would never correctly be set again, meaning
sysuid would show on the wrong orientation.
As another side effect, this should mean that all processes no longer wake up
and set their rotation angle (uselessly) on a window being mapped.