Added support for C++ theming components #2
Conversation
| @@ -1,19 +1,19 @@ | |||
| <!DOCTYPE RCC><RCC version="1.0"> | |||
There was a problem hiding this comment.
QtCreator did it :(
This commit imports work done for having C++ based theming, exporting a C++ Theme singleton object, and C++ object for each component, starting with the button. It also includes the new theming system, using JSON, and a tool to generate new components based on a description file.
|
it all looks very good to me, except the part about inner objects, like NemoThemePressedGradient... it would be good to have nested objects in the components.json definitions as well... Of course this requires a bigger effort while parsing, but it looks a bit dirty to me as it is now :( having button and its inner properties on the same level... Also, I'm no python guy (yet :D ) so I can't comment on the code generator, but I suggested few c++ related fixes (such as the use of const for setters) That said, I think you made a very good job with all the rest :) |
| source += "\n" | ||
|
|
||
| if "type" in property: | ||
| source += "void " + name + "::set" + _getUpper(propertyName) |
There was a problem hiding this comment.
could it be worth adding a "const" here?
There was a problem hiding this comment.
Look at the generated code: the consts are here if needed.
|
LGTM |
|
LGTF: Look good to Faenil :) |
Added support for C++ theming components
No description provided.