[font] Set TextField font to Open Sans, fixes NEMO#711. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also set the text field font, this was a long overdue fix. |
| // The background of the button. | ||
| background: Rectangle { | ||
| implicitWidth: 240 | ||
| implicitHeight: 50 |
There was a problem hiding this comment.
How will you achieve now that all buttons are of same height? As in e.g. http://play.qwazix.com/grog/wp-content/uploads/2013/07/SystemUI.png
locusf
changed the title
| @@ -26,6 +26,7 @@ TextFieldStyle { | |||
| selectionColor: Theme.textField.selectionColor | |||
| textColor: Theme.textField.selectedTextColor | |||
| font.pixelSize: Theme.textField.pointSize | |||
| font.family: 'Open Sans' | |||
There was a problem hiding this comment.
should it not be taken from the Theme?
Also set the font via Theme object as instructed. This is now indicated in glacier.json.
|
lgtm if tested:) |
|
Yup tested just now. |
|
LGTM too |
|
Ok merging. |
locusf
added a commit
that referenced
this pull request
Dec 8, 2014
[font] Set TextField font to Open Sans, fixes NEMO#711.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.