New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theming #41
Theming #41
Conversation
|
Potentially might be a good idea to add animation durations (opacity fade duration, menu expansion duration, etc) to the Theme, to avoid hardcoding stuff everywhere. One other thing I see often is opacity values (e.g. for disabled options, etc) so it might be worth standardising theme values for that sort of thing too. |
|
I think commit ready |
|
No other page works in "Glacier UI" example application than the main.qml. All other pages give the basic Also IMO font sizes are quite small(Maybe also itemHeights). |
|
@eekkelund Qt 5.6 ? |
|
@neochapay Yes |
|
Use this example/touch/main.qml file https://gist.github.com/neochapay/81d4938c1a0f552a7b05dfe8533ff8e4 and send me log when you try run selectRoller and listView pages. |
|
All the other pages started to work except listView, here is the output: |
|
@eekkelund try clean build or remove examples/touch/qrc_* |
|
@eekkelund @neochapay are you guys ready to merge this? |
|
@locusf i have some errors with examples and i can`t check...but if @eekkelund says all is ok - i think we can merge that |
|
Well the example application doesn't work ATM at all, only the first page is visible. If you are able to fix this, @neochapay, then merge is ok for me. If you don't have time I could try to check what is causing the problem. |
|
Ready |
|
@locusf path of ? |
|
All tests pass now for me. Listview isn't visible due to changes in sailfish qt, nothing to do with @neochapay code. |
Add theming support. Now we have 28 parametrs size, colors and other
This is almost all the parameters that we need IMHO. All parametrs can be changed in json theme file and all application can change theme. I do not think it's a good idea but i dont know how to use that functional correctly...