Remove RTC WKALM programming, notify DSME of the next non-boot event #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSME handles RTC programming, including WKALM. DSME listens to the timed signal next_bootup_event and programs RTC wakeup alarms accordingly.
|
DSME changes to handle the updated next_bootup_event signal (+other stuff) are reviewed here: nemomobile/dsme#3 For the specific DSME code that reads the updated signal, see spiiroin/dsme@a737371#L1R1099 |
|
Code changes look ok to me. But since we changed the signal: does timed support introspection / is the signal content changed there too? The time value description is bit leading in the commit message: while the device is up and running, both (1) and (2) are used for rtc alarm programming -> the device will resume from suspend to handle alarms. At shutdown (1) is programmed to rtc -> the device will power up to serve alarms with the boot flag set. |
added 2 commits
March 1, 2013 12:31
The signal has two parameters, int next_boot_event, and int next_non_boot_event. Both are timestamps in the form of seconds since the Unix epoch. The former gives the trigger date of the next event with the boot flag enabled, and the latter the trigger date of the next event without the boot flag enabled. While the device is up and running, DSME uses both parameters to program the RTC to make the device wake up from suspend to handle events. At shutdown DSME programs the RTC to power up the device to trigger the next event with the boot flag set, whose trigger date is defined by the paramter next_boot_event.
|
Updated pull request, changes:
|
|
ok by me |
pgerdt
pushed a commit
that referenced
this pull request
Mar 4, 2013
Remove RTC WKALM programming, notify DSME of the next non-boot event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove RTC WKALM programming. DSME handles RTC programming, including WKALM. DSME listens to the timed signal next_bootup_event and programs RTC wakeup alarms accordingly.
Add timestamp of next non-boot event to DBUS signal next_bootup_event. The signal has two parameters, int next_boot_event, and int next_non_boot_event. Both are timestamps in the form of seconds since the Unix epoch. The former gives the trigger date of the next event with the boot flag enabled, and the latter the trigger date of the next event without the boot flag enabled.
While the device is up and running, DSME uses both parameters to program the RTC to make the device wake up from suspend to handle events.
At shutdown DSME programs the RTC to power up the device to trigger the next event with the boot flag set, whose trigger date is defined by the paramter next_boot_event.
Make signal next_bootup_event show up in DBUS introspection