[timed] Change location of time zone link that timed manages #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -346,7 +348,7 @@ int source_settings::check_target(string path) | |||
| return -1 ; | |||
| // The file exists and is a regular file ! | |||
| ino_t inode = s.st_ino ; | |||
| res = stat("/etc/localtime", &s) ; | |||
| res = stat("LOCALTIMELINK", &s) ; | |||
|
Updated pull request:
|
|
LGTM |
| tzset() ; | ||
| if(unlink_res) | ||
| { | ||
| log_error("can't unlink /etc/localtime: %m") ; | ||
| log_error("can't unlink LOCALTIMELINK: %m") ; |
There was a problem hiding this comment.
I guess we want to log the path, not the macro name?
"can't unlink "LOCALTIMELINK": %m"
or
"can't unlink %s: %m", LOCALTIMELINK
|
Updated pull request:
|
|
|
||
| %pre | ||
| groupadd -rf timed | ||
| groupadd-user timed |
There was a problem hiding this comment.
For these you need also to have Requires: lines set properly for oneshot.
There was a problem hiding this comment.
Done, added %{_oneshot_groupadd_requires_pre}, %{_oneshot_groupadd_requires_post}, other oneshot requires are already present.
Timed links time zone files in /usr/share/zoneinfo to /var/lib/timed, for example /var/lib/timed/localtime -> /usr/share/zoneinfo/Europe/Helsinki The system time zone /etc/localtime is in turn linked to /var/lib/timed/localtime, so that it follows the time zone set by timed. The directory /var/lib/timed can be modified by root and members of group timed, timed installation creates group timed and adds the default user to the group. These changes are required as timed is not run with root privileges, and it does not have the rights to change /etc/localtime.
|
OK |
pgerdt
pushed a commit
that referenced
this pull request
Aug 7, 2013
[timed] Change location of time zone link that timed manages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timed links time zone files in /usr/share/zoneinfo to
/var/lib/timed, for example
/var/lib/timed/localtime -> /usr/share/zoneinfo/Europe/Helsinki
The system time zone /etc/localtime is in turn linked to
/var/lib/timed/localtime, so that it follows the time zone
set by timed.
These changes are required as timed is not run with root
priviledges, and it does not have the rights to change
/etc/localtime.