Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test automation voland service #7

Merged
merged 9 commits into from Feb 5, 2013
Merged

Added test automation voland service #7

merged 9 commits into from Feb 5, 2013

Conversation

spiiroin
Copy link
Contributor

The command line tool ta_voland_service implements
com.nokia.voland and com.nokia.ta_voland interfaces
on D-Bus system bus for use with test automation.

The command line tool ta_voland_service implements
com.nokia.voland and com.nokia.ta_voland interfaces
on D-Bus system bus for use with test automation.
@pgerdt
Copy link

pgerdt commented Jan 28, 2013

I propose that we move the tests directory to the root directory: src and tests would be siblings. See pull request #8

printf("change dialog %u -> %u\n", dialog_cookie, now);
}
dialog_cookie = now;
voland_stack_retring_timeout();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor documentational code comprehension issue: what does "retring" stand for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how it ended up looking like that, but it should have been "rethink"

@pgerdt
Copy link

pgerdt commented Jan 28, 2013

A readme file would perhaps be a good addition, with information about

  • how to run the application: what output to expect, example(s), etc
  • outline of what the code/modules does, explaining (rx/tx parts for non-radio persons :): this would help people looking for code/info about how to write a voland client, etc
  • what is the role of ta_voland, how does it fit in with voland, why two dbus services, etc?

Apply "voland_autoreply_" prefix for user action functionality.
Common "voland_stack_" prefix used for all functions.
Now uses common prefix "voland_parse_" for function names.

Documented the dbus message format the parsers expect to see.
Simulates "system startup ready" signaling timed excepts to see.
spiiroin added a commit that referenced this pull request Feb 5, 2013
Added test automation voland service
@spiiroin spiiroin merged commit 4ab9a3d into nemomobile:master Feb 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants