Automatic time update/NITZ unit tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated pull request: added missing files. |
|
|
||
| #define log_debug(msg, ...) \ | ||
| do { \ | ||
| printf("log_debug: "); printf(msg, ##__VA_ARGS__); printf("\n"); \ |
There was a problem hiding this comment.
Minor, but If the msg is always literal string, then you could do just: printf("log_debug: " msg "\n", ##VA_ARGS);
|
Updated pull request, changes:
[1] spiiroin about tests/ut_networktime/qmlogstub.h: Minor, but If the msg is always literal string, then you could do just: printf("log_debug: " msg "\n", ##VA_ARGS); |
|
The changes in this pull request obviously require changes to the spec file used in build.pub.meego.com timed OBS project. Here's a OBS branch of timed that includes changes in this pull request and has an updated spec file. |
added 4 commits
January 29, 2013 16:19
Move tests.xml to test directory, add automatic time update related unit tests, remove obsolete tests.
Test setup changes: test.xml is installed to directory /opt/tests/timed-tests/test-definition.
Rename src/root.pro to src/src.pro for a smoother build setup.
|
Updated pull request, added copyright headers. |
pgerdt
pushed a commit
that referenced
this pull request
Jan 31, 2013
Automatic time update/NITZ unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for "public" classes included in the handling of automatic time/timezone update: NetworkTimeInfo, NetworkTime, NetworkOperator.
In addition, adds .gitignore