[port] Port to Qt5/QtQuick2 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,8 +0,0 @@ | |||
| [Unit] | |||
There was a problem hiding this comment.
deleting this is wrong, you want to have the dialer UI running at UX startup
There was a problem hiding this comment.
check the other service file (the dbus one). Why do we need this one as well?
|
other than the service parts, looks good |
|
Added back voicecall-ui-prestart.service file where I got rid of xorg dependency and also added the [Install] section |
|
Heh, this actually isn't gaining anything from the qtcomponents booster over what the qtquick2 booster would offer, because it creates its own QQuickView. That's sad. Unrelated, though. LGTM, merge away |
|
Yeah, that has to be added asap. As you said, unrelated though :) I'm merging ;) Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...plus refactoring and fixing of QML and packaging issues.
Can't test the UI properly because of the theme manager issues we still have on Nemo Wayland.
And being on a VM doesn't help testing gsm functionality either :)
So we'll postpone testing to the moment when Nemo Wayland will have a working non-VM image