Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccountRestrictionMosaic transaction can (incorrectly) be created with zero modifications #49

Closed
ravitej-aluru opened this issue Oct 24, 2019 · 1 comment

Comments

@ravitej-aluru
Copy link

@ravitej-aluru ravitej-aluru commented Oct 24, 2019

Description: When a user creates a transaction to add AccountRestrictionMosaic, the user is not alerted even if there are no modifications in the submitted transaction

Steps:
Scenario: An account blocks receiving transactions containing a specific asset
Given Alex has the following assets registered and active:
| ticket |
| voucher |
When Bobby blocks receiving transactions containing no assets
Then Bobby should receive the error "Failure_RestrictionAccount_Invalid_Modification" (or something similar along these lines)

Actual Outcome: The transaction goes through without any errors and the accountRestriction collection in the database contains zero elements for the modifications node.
The user will be under the impression that a restriction has been added to the account when in fact it is not. From usability perspective, I think it is important to let the user know by way of an error message or at least a warning that the restriction will actually not result in any restriction.

Please see the conversation in Slack using the link below for more details.

gimer pushed a commit that referenced this issue Nov 8, 2019
### Added
 - Support for `make install`

### Changed
 - Add hash variant name to binary descriptions
 - Realign transaction binary layouts to maximize alignment of fields
 - Add `AggregateTransaction::TransactionHash` that contains merkle hash of component transactions
 - Store `Version` and `Network` directly in `EntityBody`

### Fixed
 - GitHub Issues: #45 #46 #47 #48 #49 #50
 - Bug in harvester `StateHash` calculation when `transactionSelectionStrategy` is not `oldest`
 - Fix remaining UBSAN and TSAN warnings
@Jaguar0625

This comment has been minimized.

Copy link
Member

@Jaguar0625 Jaguar0625 commented Nov 8, 2019

Fixed in 621ccbd [v0.9.0.1].

@Jaguar0625 Jaguar0625 closed this Nov 8, 2019
Jaguar0625 pushed a commit that referenced this issue Nov 14, 2019
### Added
 - Support for `make install`

### Changed
 - Add hash variant name to binary descriptions
 - Realign transaction binary layouts to maximize alignment of fields
 - Add `AggregateTransaction::TransactionHash` that contains merkle hash of component transactions
 - Store `Version` and `Network` directly in `EntityBody`

### Fixed
 - GitHub Issues: #45 #46 #47 #48 #49 #50
 - Bug in harvester `StateHash` calculation when `transactionSelectionStrategy` is not `oldest`
 - Fix remaining UBSAN and TSAN warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.