Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gets blockchain storage info. #37

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@NemTechCN
Copy link
Contributor

commented May 29, 2019

Gets blockchain storage info.

@coveralls

This comment has been minimized.

Copy link

commented May 29, 2019

Pull Request Test Coverage Report for Build 62

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.732%

Totals Coverage Status
Change from base Build 60: 0.0%
Covered Lines: 51
Relevant Lines: 59

💛 - Coveralls
1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented May 29, 2019

Pull Request Test Coverage Report for Build 62

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.732%

Totals Coverage Status
Change from base Build 60: 0.0%
Covered Lines: 51
Relevant Lines: 59

💛 - Coveralls
@rg911
Copy link
Member

left a comment

The code change looks okay.
However, Dragon's approaching soon, I'd suggest further changes to make it Dragon compatible.

nemtech/nem2-sdk-typescript-javascript#149

@dgarcia360

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Hi @NemTechCN , the code looks nice! To follow the API approach, I would prefer if you could move the command either to nem2-cli diagnostic or nem2-cli node instead of nem2-cli blockchain. Thanks!


const profile = this.getProfile(options);

const blockchainHttp = new BlockchainHttp(profile.url);

This comment has been minimized.

Copy link
@dgarcia360

dgarcia360 Jun 19, 2019

Member

BlockchainHttp is now BlockHttp

blockchainHttp.getDiagnosticStorage().subscribe((storage) => {
this.spinner.stop(true);

console.log('numBlocks: ' + storage.numBlocks);

This comment has been minimized.

Copy link
@dgarcia360

dgarcia360 Jun 19, 2019

Member

How about putting all the output text into a variable? Doing so you could write one single console.log(text) at the end.

@dgarcia360

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

@NemTechCN This PR is almost ready to be merged, do you want to continue it? Thanks!

cc/ @evias

import {ProfileCommand, ProfileOptions} from '../../profile.command';

@command({
description: 'Blockchain storage',

This comment has been minimized.

Copy link
@dgarcia360

dgarcia360 Jul 19, 2019

Member

Get blockchain storage info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.