Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get owned namespaces #45

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
4 participants
@NemTechCN
Copy link

commented Jun 17, 2019

No description provided.

NemTechCN and others added some commits Jun 5, 2019

@coveralls

This comment has been minimized.

Copy link

commented Jun 17, 2019

Pull Request Test Coverage Report for Build 96

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.889%

Totals Coverage Status
Change from base Build 92: 0.0%
Covered Lines: 52
Relevant Lines: 60

💛 - Coveralls

@NemTechCN NemTechCN referenced this pull request Jun 17, 2019

Closed

Get owned namespaces #33

@dgarcia360

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Good job @NemTechCN! It will be great to have the possibility to pass the address to check as an option.

@dgarcia360

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

@NemTechCN We can get rid of the "optional" option picking the profile address by default, but overwriting it if the address option is set.

See how we are doing it with nem2-cli account info:

https://github.com/nemtech/nem2-cli/blob/master/src/commands/account/info.ts#L53

@NemTechCN

This comment has been minimized.

Copy link
Author

commented Jun 18, 2019

Thank you for your advice.

Show resolved Hide resolved src/commands/namespace/owns.ts Outdated
Show resolved Hide resolved src/commands/namespace/owns.ts Outdated
} else {
let text = '';
namespacesInfo.map(namespaceInfo => {
namespaceService.namespace(namespaceInfo.id).subscribe(namespace => {

This comment has been minimized.

Copy link
@dgarcia360

dgarcia360 Jun 19, 2019

Member

I don't think you have to call the namespaceService. Try to fetch the namespace name doing:

namespaceInfo.id.fullName

Show resolved Hide resolved src/commands/namespace/owns.ts Outdated
Show resolved Hide resolved src/commands/namespace/owns.ts Outdated
Show resolved Hide resolved src/commands/namespace/owns.ts Outdated
Show resolved Hide resolved src/commands/namespace/owns.ts Outdated
Show resolved Hide resolved src/commands/namespace/owns.ts Outdated
@dgarcia360

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Closed in favor of #45

@dgarcia360 dgarcia360 closed this Jul 5, 2019

@dgarcia360

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

btw @NemTechCN, thanks for your PR! It is already merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.