Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Properties #49

Closed
evias opened this issue May 9, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@evias
Copy link
Collaborator

commented May 9, 2019

Account Filter docs: https://nemtech.github.io/concepts/account-filter.html

Set account filters
const addressFilterExample = Filter.createForAddress(
PropertyModificationType.Add, // Options: Add, Remove
address
);

const mosaicFilterExample = Filter.createForMosaic(
PropertyModificationType.Add,
mosaicId
);

const mosaicFilterExample = Filter.createForEntityType(
PropertyModificationType.Add,
TransactionType.TRANSFER
);

AccountPropertiesTransaction.create(
Deadline.create(),
PropertyType.BlockAddress, // Allow(Block)Address, Allow(Block)Mosaic, Allow(Block)EntityType
[addressFilterExample],
NetworkType.MIJIN_TEST);
Get account properties from an account
accountHttp.getProperties(publicAccount: PublicAccount, queryParams: QueryParams): Observable<AccountProperties[]>

--

Please have a look at the PR in the nem2-sdk-typescript-javascript project to get an idea of how this can be integrated.

@evias evias added the enhancement label May 9, 2019

@evias evias added this to the Bison - Cow milestone May 9, 2019

@fullcircle23 fullcircle23 self-assigned this May 9, 2019

fullcircle23 pushed a commit that referenced this issue May 13, 2019

@fullcircle23

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

Completed domain model object and unit testing.
Commit url: 0ec85b6

@fullcircle23

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

Raised following question in Slack #sig-api:

I find the Account Properties documentation, REST API reference, and TS SDK to be confusing and/or not aligned. For e.g. AccountPropertiesAddressTransaction don't correspond in the above. Another example, AccountProperty in TS SDK has aPropertyType and values (object[]) but isn't clear what are valid values.

It seems to me that 'values' can be a list of one of the following objects but I'm not 100% sure as the docs doesn't clearly define this and the unit test cases in TS SDK includes other object types in 'values':

  • Address
  • MosaicId
  • EntityType

Temporarily stopping work on this until above question is answered. Thanks.

@rg911 rg911 closed this Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.