replace_invalid: Replace final incomplete sequence #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In replace_invalid, if NOT_ENOUGH_ROOM is returned by `validate_next` then it simply means there is an incomplete sequence at the end of the input. Replace it instead of erroring out.
glebm
added a commit
to glebm/libsass
that referenced
this pull request
Nov 28, 2018
Fixes sass#2657 Incorporates the following utfcpp patches: 1. Sass addition of `retreat`. nemtrif/utfcpp#20 2. Fix for `replace_invalid` throwing on incomplete sequence at the end of the input. nemtrif/utfcpp#21
xzyfer
pushed a commit
to sass/libsass
that referenced
this pull request
Nov 28, 2018
Fixes #2657 Incorporates the following utfcpp patches: 1. Sass addition of `retreat`. nemtrif/utfcpp#20 2. Fix for `replace_invalid` throwing on incomplete sequence at the end of the input. nemtrif/utfcpp#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In replace_invalid, if
NOT_ENOUGH_ROOMis returned byvalidate_nextthen it simply means there is an incomplete sequence at the end of the input.Replace it instead of erroring out.
Example: https://github.com/sass/libsass/files/2064758/test_m001.txt