Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove everything from main namespace #78

Merged
merged 1 commit into from Jun 5, 2018
Merged

Remove everything from main namespace #78

merged 1 commit into from Jun 5, 2018

Conversation

tbekolay
Copy link
Member

@tbekolay tbekolay commented Jun 4, 2018

Instead, everything should be explicitly imported from its specific submodule.

As suggested in #77. I'll merge and do a 0.3 release once this gets an approved review.

@tbekolay
Remove everything from main namespace
f3aecf2 
Instead, everything should be explicitly imported from its
specific submodule.
jgosmann
jgosmann approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@jgosmann jgosmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tbekolay tbekolay merged commit f3aecf2 into master Jun 5, 2018
@tbekolay tbekolay deleted the empty-init branch June 5, 2018 00:47
@tbekolay tbekolay mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgosmann jgosmann jgosmann approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbekolay @jgosmann