Conversation
11 tasks
A numba-accelerated drop-in replacement for nengo.LIF. Also reorganized the setup.py extra_requires slightly to align with other nengo projects.
hunse
approved these changes
May 24, 2019
Contributor
|
Don't know why this didn't close automatically, it's merged and the merged branch is up to date with master. |
Member
|
It's because the base branch for this PR isn't master, it's |
Contributor
|
Ahh, and that's why it wouldn't let me delete the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from nengo/nengo#1482
I also reworked the
setup.pyextra_requiresslightly, since I needed to add innumbaand there wasn't an obvious place to put it. Could revert this if we want to keep requirements separated by different subcomponents (e.g. one fordeeplearning, one fornumbalif). But I figured it'd be ok to lump everything under "optional", and that's familiar for people working with other nengo projects.Based on #85, as there are some fixes in that branch needed to get nengo-extras tests passing.