Skip to content

Fix imports for Nengo 3.0#90

Merged
tbekolay merged 1 commit into
masterfrom
fix-compat
Nov 15, 2019
Merged

Fix imports for Nengo 3.0#90
tbekolay merged 1 commit into
masterfrom
fix-compat

Conversation

@drasmuss

@drasmuss drasmuss commented Nov 8, 2019

Copy link
Copy Markdown
Member

This updates Nengo Extras to be compatible with Nengo 3.0. Note that there are several tests failing, which I have not attempted to fix. This just allows Nengo Extras to be imported without error, so that the parts that do work can be used. Since we're not really actively maintaining Nengo Extras (and we may be significantly reworking it in the near future), it didn't seem worthwhile updating a bunch of legacy code at this point.

@tbekolay tbekolay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Made a few small changes in b45bd36. Going to squash that in and merge!

@tbekolay tbekolay merged commit dab8e34 into master Nov 15, 2019
@tbekolay tbekolay deleted the fix-compat branch November 15, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants