Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulator.close should also close split networks #102

Closed
tbekolay opened this issue Sep 29, 2018 · 0 comments · Fixed by #121
Closed

Simulator.close should also close split networks #102

tbekolay opened this issue Sep 29, 2018 · 0 comments · Fixed by #121
Assignees

Comments

@tbekolay
Copy link
Member

Right now we get ResourceWarnings related to not calling self.host_sim.close() etc.

@drasmuss drasmuss self-assigned this Oct 11, 2018
drasmuss added a commit that referenced this issue Oct 11, 2018
Also adds a close method to the emulator (for consistency).

Fixes #102
drasmuss added a commit that referenced this issue Oct 12, 2018
Also adds a close method to the emulator (for consistency).

Fixes #102
hunse pushed a commit that referenced this issue Oct 26, 2018
Also adds a close method to the emulator (for consistency).

Fixes #102
hunse pushed a commit that referenced this issue Oct 29, 2018
Also adds a close method to the emulator (for consistency).

Fixes #102
hunse pushed a commit that referenced this issue Oct 31, 2018
Also adds a close method to the emulator (for consistency).

Fixes #102
hunse pushed a commit that referenced this issue Nov 1, 2018
Also adds a close method to the emulator (for consistency).

Fixes #102
hunse pushed a commit that referenced this issue Nov 2, 2018
Also adds a close method to the emulator (for consistency).

Fixes #102
hunse pushed a commit that referenced this issue Nov 2, 2018
Also adds a close method to the emulator (for consistency).

Fixes #102
tbekolay pushed a commit that referenced this issue Nov 5, 2018
Also adds a close method to the emulator (for consistency).

Fixes #102.
tbekolay pushed a commit that referenced this issue Nov 11, 2018
Also adds a close method to the emulator (for consistency).

Fixes #102.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants