New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulator.close should also close split networks #102

Closed
tbekolay opened this Issue Sep 29, 2018 · 0 comments

Comments

2 participants
@tbekolay
Member

tbekolay commented Sep 29, 2018

Right now we get ResourceWarnings related to not calling self.host_sim.close() etc.

@drasmuss drasmuss added this to Needs triage in Issue triage via automation Oct 10, 2018

@drasmuss drasmuss moved this from Needs triage to Low priority in Issue triage Oct 10, 2018

@tbekolay tbekolay added this to To do in 0.4 release Oct 11, 2018

@drasmuss drasmuss self-assigned this Oct 11, 2018

drasmuss added a commit that referenced this issue Oct 11, 2018

Close sub-simulators on close
Also adds a close method to the emulator (for consistency).

Fixes #102

@drasmuss drasmuss referenced this issue Oct 11, 2018

Merged

Close sub-simulators on close #121

1 of 1 task complete

drasmuss added a commit that referenced this issue Oct 12, 2018

Close sub-simulators on close
Also adds a close method to the emulator (for consistency).

Fixes #102

hunse added a commit that referenced this issue Oct 26, 2018

Close sub-simulators on close
Also adds a close method to the emulator (for consistency).

Fixes #102

hunse added a commit that referenced this issue Oct 29, 2018

Close sub-simulators on close
Also adds a close method to the emulator (for consistency).

Fixes #102

hunse added a commit that referenced this issue Oct 31, 2018

Close sub-simulators on close
Also adds a close method to the emulator (for consistency).

Fixes #102

hunse added a commit that referenced this issue Nov 1, 2018

Close sub-simulators on close
Also adds a close method to the emulator (for consistency).

Fixes #102

hunse added a commit that referenced this issue Nov 2, 2018

Close sub-simulators on close
Also adds a close method to the emulator (for consistency).

Fixes #102

hunse added a commit that referenced this issue Nov 2, 2018

Close sub-simulators on close
Also adds a close method to the emulator (for consistency).

Fixes #102

tbekolay added a commit that referenced this issue Nov 5, 2018

Close sub-simulators on close
Also adds a close method to the emulator (for consistency).

Fixes #102.

@tbekolay tbekolay closed this in #121 Nov 5, 2018

Issue triage automation moved this from Low priority to Closed Nov 5, 2018

@drasmuss drasmuss moved this from To do to Done in 0.4 release Nov 6, 2018

tbekolay added a commit that referenced this issue Nov 11, 2018

Close sub-simulators on close
Also adds a close method to the emulator (for consistency).

Fixes #102.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment