New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include snips directory when building dist #134

Merged
merged 1 commit into from Nov 5, 2018

Conversation

2 participants
@drasmuss
Contributor

drasmuss commented Oct 31, 2018

The snips folder is included in our pypi release, but by default it doesn't get included in the installation when you actually pip install nengo-loihi (because it doesn't contain any python files). This modifies setup.py to tell it to include the snips folder.

@drasmuss drasmuss added this to In progress in PR status via automation Oct 31, 2018

PR status automation moved this from In progress to Reviewer approved Nov 4, 2018

@tbekolay

Thanks @drasmuss! I can confirm this fixes #35 too. Merging.

@tbekolay tbekolay added this to To do in 0.4 release Nov 4, 2018

@tbekolay tbekolay moved this from To do to Needs review in 0.4 release Nov 4, 2018

@tbekolay tbekolay force-pushed the setup-snips branch from 6b2b259 to 81176fd Nov 4, 2018

@tbekolay tbekolay merged commit 81176fd into master Nov 5, 2018

1 check passed

codecov/patch Coverage not affected when comparing a75d7f6...81176fd
Details

PR status automation moved this from Reviewer approved to Done Nov 5, 2018

0.4 release automation moved this from Needs review to Done Nov 5, 2018

@tbekolay tbekolay deleted the setup-snips branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment