Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
drasmuss
added this to In progress
in PR status
via automation
Nov 20, 2018
drasmuss
added
the
ready for review
label
Nov 20, 2018
drasmuss
moved this from In progress
to Needs review
in PR status
Nov 26, 2018
drasmuss
self-assigned this
Nov 26, 2018
tbekolay
added this to To do
in 0.4 release
Nov 30, 2018
tbekolay
moved this from To do
to Needs review
in 0.4 release
Nov 30, 2018
This comment has been minimized.
This comment has been minimized.
|
I think this is also something we should have in 0.4.0. I looked it over and I think this is basically good to go, except that we should add in the Nengo Loihi logo from nengo/design#7 as currently there's no other way to get back to the index page. Aside from that, is there anything else you want to do in this branch @drasmuss ? |
tbekolay
force-pushed the
new-docs
branch
from
af1333c
to
5b24cf2
Nov 30, 2018
This comment has been minimized.
This comment has been minimized.
|
Also a heads up that I rebased this! |
drasmuss
removed their assignment
Nov 30, 2018
This comment has been minimized.
This comment has been minimized.
|
Pushed some fixups, and added a logo and favicon from nengo/design#7. Took a look at the built docs and they look good to me! |
docs/conf.py Outdated
This comment has been minimized.
This comment has been minimized.
|
Added a fixup to change the logo and adjust the width (with the new nengo-sphinx-theme release). |
PR status
automation
moved this from Needs review
to Reviewer approved
Dec 5, 2018
tbekolay
approved these changes
Dec 5, 2018
Pushed some quick fixups for the latest nengo-sphinx-theme release, will merge if you're happy with it now @drasmuss
This comment has been minimized.
This comment has been minimized.
|
Looks good to me. I added a commit to apply the patch from nengo/nengo-bones#3. Not strictly necessary since we don't allow PR builds in this repo, but doesn't hurt. |
tbekolay
removed
the
ready for review
label
Dec 5, 2018
drasmuss
added some commits
Nov 20, 2018
drasmuss commentedNov 20, 2018
Switches the documentation to the new theme, and adds versioning to the build process.