Skip to content

Documentation updates #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 5, 2018
Merged

Documentation updates #143

merged 4 commits into from
Dec 5, 2018

Conversation

@drasmuss
Copy link
Member

@drasmuss drasmuss commented Nov 20, 2018

Switches the documentation to the new theme, and adds versioning to the build process.

@drasmuss drasmuss self-assigned this Nov 26, 2018
@tbekolay
Copy link
Member

tbekolay commented Nov 30, 2018

I think this is also something we should have in 0.4.0. I looked it over and I think this is basically good to go, except that we should add in the Nengo Loihi logo from nengo/design#7 as currently there's no other way to get back to the index page. Aside from that, is there anything else you want to do in this branch @drasmuss ?

@tbekolay
Copy link
Member

tbekolay commented Nov 30, 2018

Also a heads up that I rebased this!

@drasmuss drasmuss removed their assignment Nov 30, 2018
@drasmuss
Copy link
Member Author

drasmuss commented Nov 30, 2018

Pushed some fixups, and added a logo and favicon from nengo/design#7. Took a look at the built docs and they look good to me!

tbekolay
tbekolay reviewed Nov 30, 2018
View reviewed changes
@drasmuss
Copy link
Member Author

drasmuss commented Dec 3, 2018

Added a fixup to change the logo and adjust the width (with the new nengo-sphinx-theme release).

tbekolay
tbekolay approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some quick fixups for the latest nengo-sphinx-theme release, will merge if you're happy with it now @drasmuss

@drasmuss
Copy link
Member Author

drasmuss commented Dec 5, 2018 •
edited
Loading

Looks good to me. I added a commit to apply the patch from nengo/nengo-bones#3. Not strictly necessary since we don't allow PR builds in this repo, but doesn't hurt.

@tbekolay tbekolay merged commit 90bcf83 into master Dec 5, 2018
@tbekolay tbekolay deleted the new-docs branch December 5, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbekolay tbekolay tbekolay approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drasmuss @tbekolay