New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #143

Merged
merged 4 commits into from Dec 5, 2018

Conversation

2 participants
@drasmuss
Contributor

drasmuss commented Nov 20, 2018

Switches the documentation to the new theme, and adds versioning to the build process.

@drasmuss drasmuss added this to In progress in PR status via automation Nov 20, 2018

@drasmuss drasmuss moved this from In progress to Needs review in PR status Nov 26, 2018

@drasmuss drasmuss self-assigned this Nov 26, 2018

@tbekolay tbekolay added this to To do in 0.4 release Nov 30, 2018

@tbekolay tbekolay moved this from To do to Needs review in 0.4 release Nov 30, 2018

@tbekolay

This comment has been minimized.

Member

tbekolay commented Nov 30, 2018

I think this is also something we should have in 0.4.0. I looked it over and I think this is basically good to go, except that we should add in the Nengo Loihi logo from nengo/design#7 as currently there's no other way to get back to the index page. Aside from that, is there anything else you want to do in this branch @drasmuss ?

@tbekolay tbekolay force-pushed the new-docs branch from af1333c to 5b24cf2 Nov 30, 2018

@tbekolay

This comment has been minimized.

Member

tbekolay commented Nov 30, 2018

Also a heads up that I rebased this!

@drasmuss drasmuss removed their assignment Nov 30, 2018

@drasmuss

This comment has been minimized.

Contributor

drasmuss commented Nov 30, 2018

Pushed some fixups, and added a logo and favicon from nengo/design#7. Took a look at the built docs and they look good to me!

Show resolved Hide resolved docs/conf.py Outdated
@drasmuss

This comment has been minimized.

Contributor

drasmuss commented Dec 3, 2018

Added a fixup to change the logo and adjust the width (with the new nengo-sphinx-theme release).

PR status automation moved this from Needs review to Reviewer approved Dec 5, 2018

@tbekolay

Pushed some quick fixups for the latest nengo-sphinx-theme release, will merge if you're happy with it now @drasmuss

@drasmuss

This comment has been minimized.

Contributor

drasmuss commented Dec 5, 2018

Looks good to me. I added a commit to apply the patch from nengo/nengo-bones#3. Not strictly necessary since we don't allow PR builds in this repo, but doesn't hurt.

@tbekolay tbekolay force-pushed the new-docs branch from a013d31 to 90bcf83 Dec 5, 2018

@tbekolay tbekolay merged commit 90bcf83 into master Dec 5, 2018

1 check passed

codecov/patch Coverage not affected when comparing e926e57...90bcf83
Details

PR status automation moved this from Reviewer approved to Done Dec 5, 2018

0.4 release automation moved this from Needs review to Done Dec 5, 2018

@tbekolay tbekolay deleted the new-docs branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment