Skip to content

Documentation updates - #143

Merged
tbekolay merged 4 commits into
masterfrom
new-docs
Dec 5, 2018
Merged

Documentation updates#143
tbekolay merged 4 commits into
masterfrom
new-docs

Conversation

@drasmuss

@drasmuss drasmuss commented Nov 20, 2018

Copy link
Copy Markdown
Member

Switches the documentation to the new theme, and adds versioning to the build process.

@drasmuss drasmuss self-assigned this Nov 26, 2018
@tbekolay

tbekolay commented Nov 30, 2018

Copy link
Copy Markdown
Member

I think this is also something we should have in 0.4.0. I looked it over and I think this is basically good to go, except that we should add in the Nengo Loihi logo from nengo/design#7 as currently there's no other way to get back to the index page. Aside from that, is there anything else you want to do in this branch @drasmuss ?

@tbekolay

tbekolay commented Nov 30, 2018

Copy link
Copy Markdown
Member

Also a heads up that I rebased this!

@drasmuss drasmuss removed their assignment Nov 30, 2018
@drasmuss

drasmuss commented Nov 30, 2018

Copy link
Copy Markdown
Member Author

Pushed some fixups, and added a logo and favicon from nengo/design#7. Took a look at the built docs and they look good to me!

tbekolay
tbekolay reviewed Nov 30, 2018
View reviewed changes
Comment thread docs/conf.py Outdated
@drasmuss

drasmuss commented Dec 3, 2018

Copy link
Copy Markdown
Member Author

Added a fixup to change the logo and adjust the width (with the new nengo-sphinx-theme release).

tbekolay
tbekolay approved these changes Dec 5, 2018
View reviewed changes

@tbekolay tbekolay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some quick fixups for the latest nengo-sphinx-theme release, will merge if you're happy with it now @drasmuss

@drasmuss

drasmuss commented Dec 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Looks good to me. I added a commit to apply the patch from nengo/nengo-bones#3. Not strictly necessary since we don't allow PR builds in this repo, but doesn't hurt.

@tbekolay
tbekolay merged commit 90bcf83 into master Dec 5, 2018
@tbekolay
tbekolay deleted the new-docs branch December 5, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbekolay tbekolay tbekolay approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drasmuss @tbekolay