Test probes #169
Test probes #169
Conversation
tbekolay
left a comment
tbekolay
left a comment
There was a problem hiding this comment.
Looking good! I have a few questions in inline comments and we should add a changelog entry, as this fixes bugs and supports lif.min_voltage. This may also allow some Nengo tests to pass, though I don't see any xpasses in TravisCI. It could be a simple tolerance issue though since Loihi min voltages are rounded, in which case we would have to wait for pytest-allclose to allow changing tolerances, so probably let's not worry about the Nengo tests for now.
The part of the coverage diff that isn't covered is on the chip (loihi_interface.py stuff), so another question is whether to wait for the CI running on hardware stuff. My vote would be no, but this also will be easy to rebase later on so either way 🤷
nengo_loihi/loihi_interface.py
Outdated
| synapse = cx_probe.synapse | ||
| rng = None | ||
| step = (synapse.make_step(shape, shape, dt, rng, dtype=data.dtype) | ||
| step = (synapse.make_step(shape, shape, dt, rng, dtype=np.float32) |
There was a problem hiding this comment.
Any particular reason for float32 over float64 here? My default would be float64 since that's what float and np.float_ are.
There was a problem hiding this comment.
Just to use less memory when we have a lot of probe data. Since the underlying values are all limited precision (since they come from Loihi), I figured that not much would be lost by using float32 instead of float64.
nengo_loihi/loihi_interface.py
Outdated
| if cx_probe.use_snip: | ||
| data = self._snip_probe_data[cx_probe] | ||
| if cx_probe.synapse is not None: | ||
| data = np.asarray(data, dtype=np.float32) |
nengo_loihi/loihi_cx.py
Outdated
|
|
||
| def configure_lif(self, tau_rc=0.02, tau_ref=0.001, vth=1, dt=0.001): | ||
| def configure_lif(self, tau_rc=0.02, tau_ref=0.001, vth=1, dt=0.001, | ||
| min_voltage=0): |
There was a problem hiding this comment.
Since we're touching this, can we add a docstring and document these parameters?
|
Addressed the requested changes. I've also added changelogs for both the probe fixes and the min_voltage. |
hunse
force-pushed
the
test-probes
branch
2 times, most recently
from
c02f7e7 to
1728e5b
Compare
In the snip, the data is int32. When being read by Python, it needs to be explicitly interpreted as int32, otherwise it treats it as int64 and negative numbers become large positive numbers. This should fix probing of negative neuron inputs and voltages.
drasmuss
force-pushed
the
test-probes
branch
2 times, most recently
from
523793e to
8888669
Compare
|
Fixups look good to me. |
Document CxGroup.configure* functions
These probes were untested and not working correctly on chip test_voltage_decode no longer hangs
This adds a test for neuron input (current) probes, which were not working correctly (due to negative values not being cast correctly, and integers not being filtered correctly). This also corrects both these issues.
TODO:
min_voltage < 0for e.g. LIF neurons?