New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning instead of error for progress bars #187

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@drasmuss
Copy link
Contributor

drasmuss commented Feb 8, 2019

The GUI automatically tries to run with progress_bar=True, so raising a warning instead of an error allows the GUI to run successfully.

@hunse

hunse approved these changes Feb 8, 2019

Copy link
Contributor

hunse left a comment

LGTM. Just don't forget to put the PR link in the changelog message.

@hunse

This comment has been minimized.

Copy link
Contributor

hunse commented Feb 8, 2019

I just added a match to the warning test, as well. We should really try to use that, particularly when testing for warnings, but even for exceptions, too. Otherwise, any warning will satisfy the check, and we've got a lot of warnings.

@hunse hunse force-pushed the fix-gui branch from a43fa7d to 410ca22 Feb 8, 2019

@hunse hunse merged commit 410ca22 into master Feb 8, 2019

@tbekolay tbekolay deleted the fix-gui branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment