Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise warning instead of error for progress bars #187

Merged
merged 1 commit into from Feb 8, 2019
Merged

Raise warning instead of error for progress bars #187

merged 1 commit into from Feb 8, 2019

Conversation

drasmuss
Copy link
Member

@drasmuss drasmuss commented Feb 8, 2019

The GUI automatically tries to run with progress_bar=True, so raising a warning instead of an error allows the GUI to run successfully.

hunse
hunse approved these changes Feb 8, 2019
View reviewed changes
Copy link
Collaborator

@hunse hunse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just don't forget to put the PR link in the changelog message.

@hunse
Copy link
Collaborator

hunse commented Feb 8, 2019

I just added a match to the warning test, as well. We should really try to use that, particularly when testing for warnings, but even for exceptions, too. Otherwise, any warning will satisfy the check, and we've got a lot of warnings.

@hunse hunse merged commit 410ca22 into master Feb 8, 2019
@tbekolay tbekolay deleted the fix-gui branch February 12, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunse hunse hunse approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drasmuss @hunse