Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with NxSDK 0.8 #188

merged 1 commit into from Feb 12, 2019

Working with NxSDK 0.8 #188

merged 1 commit into from Feb 12, 2019


Copy link

@hunse hunse commented Feb 12, 2019

Changes to support new NxSDK 0.8

Copy link
Collaborator Author

hunse commented Feb 12, 2019

Ok, this should all be working and backwards compatible. Ready for review.

I wanted to use the new nxsdk_version in at the start of HardwareInterface, but unfortunately that breaks our tests where we monkeypatch the version to test our errors/warnings.

@tbekolay tbekolay force-pushed the nxsdk08 branch 2 times, most recently from 49c35c6 to 5eba282 Compare February 12, 2019 20:47
Copy link

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, made a few minor changes in squash commits; see those commit for details. This needs a changelog entry. I can add that in the merge but wanted to push this out quickly so @hunse can OK the squashes ASAP.

We do this in a backwards compatible way, so we still support
0.7.0 and 0.7.5, though we are not guaranteeing future support
of all NxSDK versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants