Skip to content

Working with NxSDK 0.8 - #188

Merged
tbekolay merged 1 commit into
masterfrom
nxsdk08
Feb 12, 2019
Merged

tbekolay merged 1 commit into
masterfrom
nxsdk08

Conversation

@hunse

@hunse hunse commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

Changes to support new NxSDK 0.8

@hunse

hunse commented Feb 12, 2019

Copy link
Copy Markdown
Contributor Author

Ok, this should all be working and backwards compatible. Ready for review.

I wanted to use the new nxsdk_version in nxsdk_shim.py at the start of HardwareInterface, but unfortunately that breaks our tests where we monkeypatch the version to test our errors/warnings.

@tbekolay
tbekolay force-pushed the nxsdk08 branch 2 times, most recently from 49c35c6 to 5eba282 Compare February 12, 2019 20:47

@tbekolay tbekolay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, made a few minor changes in squash commits; see those commit for details. This needs a changelog entry. I can add that in the merge but wanted to push this out quickly so @hunse can OK the squashes ASAP.

We do this in a backwards compatible way, so we still support
0.7.0 and 0.7.5, though we are not guaranteeing future support
of all NxSDK versions.
@tbekolay
tbekolay merged commit 551e36b into master Feb 12, 2019
@tbekolay
tbekolay deleted the nxsdk08 branch February 12, 2019 22:23
@drasmuss drasmuss mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants