Working with NxSDK 0.8 #188

hunse · 2019-02-12T18:11:08Z

Changes to support new NxSDK 0.8

hunse · 2019-02-12T19:20:38Z

Ok, this should all be working and backwards compatible. Ready for review.

I wanted to use the new nxsdk_version in nxsdk_shim.py at the start of HardwareInterface, but unfortunately that breaks our tests where we monkeypatch the version to test our errors/warnings.

tbekolay

LGTM, made a few minor changes in squash commits; see those commit for details. This needs a changelog entry. I can add that in the merge but wanted to push this out quickly so @hunse can OK the squashes ASAP.

We do this in a backwards compatible way, so we still support 0.7.0 and 0.7.5, though we are not guaranteeing future support of all NxSDK versions.

tbekolay force-pushed the nxsdk08 branch 2 times, most recently from 49c35c6 to 5eba282 Compare February 12, 2019 20:47

tbekolay approved these changes Feb 12, 2019

View reviewed changes

tbekolay force-pushed the nxsdk08 branch from 5eba282 to 973d36a Compare February 12, 2019 21:48

Support NxSDK 0.8.0

551e36b

We do this in a backwards compatible way, so we still support 0.7.0 and 0.7.5, though we are not guaranteeing future support of all NxSDK versions.

tbekolay force-pushed the nxsdk08 branch from 973d36a to 551e36b Compare February 12, 2019 22:23

tbekolay merged commit 551e36b into master Feb 12, 2019

tbekolay deleted the nxsdk08 branch February 12, 2019 22:23

drasmuss mentioned this pull request Feb 20, 2019

NxSDK 0.8 compatibility #165

Closed

Working with NxSDK 0.8 #188

Working with NxSDK 0.8 #188

hunse commented Feb 12, 2019

hunse commented Feb 12, 2019

tbekolay left a comment

Working with NxSDK 0.8 #188

Working with NxSDK 0.8 #188

Conversation

hunse commented Feb 12, 2019

hunse commented Feb 12, 2019

tbekolay left a comment

Choose a reason for hiding this comment