Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with NxSDK 0.8 #188

Merged
merged 1 commit into from Feb 12, 2019
Merged

Working with NxSDK 0.8 #188

merged 1 commit into from Feb 12, 2019

Conversation

@hunse
Copy link
Collaborator

@hunse hunse commented Feb 12, 2019

Changes to support new NxSDK 0.8

@hunse
Copy link
Collaborator Author

@hunse hunse commented Feb 12, 2019

Ok, this should all be working and backwards compatible. Ready for review.

I wanted to use the new nxsdk_version in nxsdk_shim.py at the start of HardwareInterface, but unfortunately that breaks our tests where we monkeypatch the version to test our errors/warnings.

@tbekolay tbekolay force-pushed the nxsdk08 branch 2 times, most recently from 49c35c6 to 5eba282 Feb 12, 2019
Copy link
Member

@tbekolay tbekolay left a comment

LGTM, made a few minor changes in squash commits; see those commit for details. This needs a changelog entry. I can add that in the merge but wanted to push this out quickly so @hunse can OK the squashes ASAP.

@tbekolay tbekolay force-pushed the nxsdk08 branch from 5eba282 to 973d36a Feb 12, 2019
We do this in a backwards compatible way, so we still support
0.7.0 and 0.7.5, though we are not guaranteeing future support
of all NxSDK versions.
@tbekolay tbekolay force-pushed the nxsdk08 branch from 973d36a to 551e36b Feb 12, 2019
@tbekolay tbekolay merged commit 551e36b into master Feb 12, 2019
1 check failed
1 check failed
@travis-ci
Travis CI - Branch Build Created
Details
@tbekolay tbekolay deleted the nxsdk08 branch Feb 12, 2019
@drasmuss drasmuss mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants