Multi-chip support, testing, and failure modes#197
Merged
Merged
Conversation
arvoelke
commented
Mar 8, 2019
arvoelke
commented
Mar 8, 2019
arvoelke
commented
Mar 9, 2019
Contributor
Author
|
Note to self: since this touches the |
Open
hunse
reviewed
Apr 10, 2019
hunse
reviewed
Apr 11, 2019
hunse
reviewed
Apr 11, 2019
This allows the allocator to be set by the user, since it is used during Simulator/HardwareInterface creation and cannot be set after.
Also: - Disallow RoundRobin allocator with snips and test that error. - Make OneToOne allocator a class. - Unit test both allocators' data structures. - Change some nxsdk_object methods to properties. - Move the board validation to happen at the build level. - Remove dead `add_axon` allocator code.
These connections are not supported by NxSDK.
hunse
approved these changes
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstracted two different methods of allocating resources to models:
OneToOne()which is the same method as before (default)RoundRobin(n_chips)which cycles through chips per block / inputRan the entire unit test suite with a manually-overwritten default of
allocator=RoundRobin(n_chips=8)(on our local host; not shown) and discovered that all failed tests currently fall into one of two categories:pop[16|32]) across chipsprecompute=False)Multi-chip support is otherwise working and the user can override / customize the behaviour, with the following notes:
RoundRobin(n_chips)gives identical behaviour across any number ofn_chipsbetween1and8inclusive (unit-tested).The current syntax for running a multi-chip simulation of the model is:
Todo: