Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Splitter refactoring #202
Closes #80. Refactors the splitter logic for adding / removing connections to occur within the builder. This consolidates the connection logic into one place (
Solves the following bugs:
Bugs that have been identified that are outside the scope of this PR:
Existing issues that should now be more readily achievable:
Other future work:
referenced this pull request
Apr 4, 2019
I ran @tcstewar's benchmark notebook with:
conditions = [ 'nengo', # the normal nengo backend 'nengo_loihi(precompute=False, target="loihi")', # using Loihi itself 'nengo_loihi(precompute=True, target="loihi")', # using Loihi itself with precompute ]
On this branch,
4 times, most recently
Apr 15, 2019
tbekolay left a comment
This is a big improvement, will make future development much easier. I made some changes within the history here, so best to see the commits one-by-one for my suggested changes. There are definitely some discussions points here, so it would be great to get @arvoelke and @hunse's thoughts and a signoff.
I added a couple very minor commits for coverage / sanity. I also rebased onto master again to pick up the testing fixes from the current/rates sync-up.
I think it's fine as is. A bunch of the weirdness with seeding can be resolved when we eventually drop support for nengo<3. This could end up simplifying a bunch of this code.
This LGTM, but we should make a card to go through the rest of the code base? e..g, There are a bunch of