Switch to nengo-bones templating #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasmuss
force-pushed
the
template-ci
branch
3 times, most recently
from
ebabeb8
to
31d6b79
Compare
10 tasks
arvoelke
reviewed
Apr 9, 2019
arvoelke
force-pushed
the
template-ci
branch
2 times, most recently
from
9443866
to
1ecba76
Compare
arvoelke
approved these changes
Apr 10, 2019
drasmuss
force-pushed
the
template-ci
branch
2 times, most recently
from
832cbe8
to
3a3b27c
Compare
1.28.0 requires pytest>=4.4, which is not supported in nengo<3.0.
The issue is that conda installs certifi, and then pip can't uninstall it because it doesn't detect it. Preventing pip from upgrading packages is okay since we disabled caching in nengo-bones. But we still need to upgrade pip itself because otherwise we get "Direct url requirement not allowed for dependencies" when doing `pip install -e .[docs]` for `abr_control`. This is not a long-term fix, but once we remove conda and then re-enable caching we shouldn't have this issue.
tbekolay
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #193 as well, since caching and pytest-xdist are now built into the template scripts.